Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for Validator.ProposerPriority #2942

Closed
ebuchman opened this issue Nov 29, 2018 · 3 comments
Closed

Write tests for Validator.ProposerPriority #2942

ebuchman opened this issue Nov 29, 2018 · 3 comments
Labels
C:consensus Component: Consensus T:test Type: Tests that need love
Milestone
v0.29.0

Comments

@ebuchman
Copy link
Contributor

A couple recent bugs were found in proposer selection that indicate insufficient testing. See #2718 for more.

#2785 and #2941 fix these bugs, but they don't include sufficient testing to prove it.

We should write more complete tests for the proposer selection across validator set changes. Likely need to reside in the state package.

Related: #1555
@ebuchman ebuchman added C:consensus Component: Consensus T:test Type: Tests that need love labels Nov 29, 2018
@ebuchman ebuchman added this to the v1.0 milestone Nov 29, 2018
@ebuchman ebuchman mentioned this issue Nov 29, 2018
Merged
4 tasks
@liamsi liamsi mentioned this issue Nov 29, 2018
Merged
4 tasks
@hendrikhofstadt hendrikhofstadt mentioned this issue Dec 2, 2018
Closed
@ebuchman ebuchman modified the milestones: v1.0, v0.29.0, v0.30.0 Jan 13, 2019
@liamsi liamsi mentioned this issue Jan 17, 2019
Merged
4 tasks
@ebuchman
Copy link
Contributor Author

@liamsi do you think we can close this based on the couple PRs worth of tests you wrote and what's additionally coming in #3049 ?

@liamsi
Copy link
Contributor

liamsi commented Jan 17, 2019

Yes, I think we can close this when #3049 is merged.

@ebuchman
Copy link
Contributor Author

Lots more tests included in #3049

Could always write more, but seems we can close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:consensus Component: Consensus T:test Type: Tests that need love
Projects
None yet
Milestone
v0.29.0
Development

No branches or pull requests
2 participants
@ebuchman @liamsi