Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: fix order of BlockID and Timestamp in Vote and Proposal #3077

Closed
ebuchman opened this issue Jan 3, 2019 · 2 comments
Closed

types: fix order of BlockID and Timestamp in Vote and Proposal #3077

ebuchman opened this issue Jan 3, 2019 · 2 comments
Labels
C:consensus Component: Consensus T:breaking Type: Breaking Change T:validator Type: Validator related
Milestone
v0.29.0

Comments

@ebuchman
Copy link
Contributor

ebuchman commented Jan 3, 2019

In #3061 it was discovered that the BlockID and Timestamp are not consistently ordered in the Proposal and Vote (both in the main struct and the Canonical signing struct). They should be. BlockID should come first.
@ebuchman ebuchman added the T:breaking Type: Breaking Change label Jan 3, 2019
@ebuchman ebuchman added this to the launch milestone Jan 3, 2019
@ebuchman ebuchman mentioned this issue Jan 3, 2019
Merged
4 tasks
@ebuchman ebuchman added C:consensus Component: Consensus T:validator Type: Validator related labels Jan 3, 2019
@ebuchman
Copy link
Contributor Author

ebuchman commented Jan 3, 2019

Make sure the signing spec is updated when we do this.

Also, we should address #3061 (review) (ie. add blockID.IsNil() and .IsComplete() methods)

@liamsi liamsi mentioned this issue Jan 3, 2019
Merged
4 tasks
@ebuchman ebuchman modified the milestones: launch, v0.29.0, v0.30.0 Jan 13, 2019
@ebuchman
Copy link
Contributor Author

Fixed in #3078

This was referenced Jan 15, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:consensus Component: Consensus T:breaking Type: Breaking Change T:validator Type: Validator related
Projects
None yet
Milestone
v0.29.0
Development

No branches or pull requests
1 participant
@ebuchman