Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: expose triggeredTimeoutPrecommit over RPC #3159

Closed
ebuchman opened this issue Jan 19, 2019 · 1 comment
Closed

consensus: expose triggeredTimeoutPrecommit over RPC #3159

ebuchman opened this issue Jan 19, 2019 · 1 comment
Labels
C:consensus Component: Consensus C:rpc Component: JSON RPC, gRPC good first issue Contributions Welcome!! T:observability Type: Observability
Milestone

Comments

@ebuchman
Copy link
Contributor

Since v0.26.0, the consensus has been changed to no longer enter into a state with Step == RoundStepPrecommitWait because we may need to start waiting the TimeoutPrecommit even before we have entered into the Precommit step.

Instead of using the RoundStepPrecommitWait as a step, we now track a bool, triggeredTimeoutPrecommit, to ensure we only trigger that timeout once per round.

However, this bool is a private field and is not exposed in any events or over RPC. Thus when debugging with /dump_consensus_state, it can be difficult to know the exact state of the consensus (ie. have we triggered this timeout or not?).

This field should be moved from the ConsensusState into the RoundState and marshalled with the rest of the RoundState fields into JSON.

We should also consider adding it to the other structs in consensus/types.

@ebuchman ebuchman added C:rpc Component: JSON RPC, gRPC C:consensus Component: Consensus T:observability Type: Observability labels Jan 19, 2019
@ebuchman ebuchman added this to the v0.30.0 milestone Jan 19, 2019
@ebuchman ebuchman added help wanted good first issue Contributions Welcome!! labels Jan 19, 2019
@milosevic milosevic mentioned this issue Jan 24, 2019
4 tasks
@ebuchman
Copy link
Contributor Author

Should be fixed in #3197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:consensus Component: Consensus C:rpc Component: JSON RPC, gRPC good first issue Contributions Welcome!! T:observability Type: Observability
Projects
None yet
Development

No branches or pull requests

1 participant