Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: return more info in the AddSignatureFromPubKey error #3672

Closed
ebuchman opened this issue May 21, 2019 · 2 comments
Closed

crypto: return more info in the AddSignatureFromPubKey error #3672

ebuchman opened this issue May 21, 2019 · 2 comments
Labels
C:crypto Component: Crypto good first issue Contributions Welcome!!

Comments

@ebuchman
Copy link
Contributor

I incorrectly assumed there was a regression in the SDK when I couldn't do a multisig tx (cosmos/cosmos-sdk#4391). Turned out I was using the wrong key! Totally my fault for not actually believing the error, but might be nice if the error had more info.

The error is currently: provided key didn't exist in pubkeys, but would be nice if it said specifically which key didn't exist, and maybe even listed the set of keys.
@ebuchman ebuchman added help wanted good first issue Contributions Welcome!! C:crypto Component: Crypto labels May 21, 2019
@alexanderbez
Copy link
Contributor

Would be happy to help here ;-)

@alexanderbez alexanderbez mentioned this issue May 23, 2019
Merged
4 tasks
@melekes
Copy link
Contributor

melekes commented May 30, 2019

#3675 was merged to develop.

@melekes melekes closed this as completed May 30, 2019
@chengwenxi chengwenxi mentioned this issue Aug 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:crypto Component: Crypto good first issue Contributions Welcome!!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melekes @ebuchman @alexanderbez