Rename Tag(s) to Event(s) #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tag was replaced with event, but in some places it still mentions tag, would be easier to understand if we tried to replace it with event to not confuse people. Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
tac0turtle
added
T:breaking
melekes
reviewed
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #4046 +/- ##
==========================================
- Coverage 67.27% 67.25% -0.02%
==========================================
Files 223 223
Lines 19342 19342
==========================================
- Hits 13012 13009 -3
- Misses 5349 5355 +6
+ Partials 981 978 -3
|
|
We need to agree on naming here. In #4077 I've proposed the new name - |
|
I am fine with that, makes more sense, will make the adjustments, |
melekes
reviewed
Nov 21, 2019
config/config.go
Outdated
| @@ -875,7 +875,7 @@ func (cfg *ConsensusConfig) ValidateBasic() error { | |||
| // TxIndexConfig | |||
|
|
|||
| // TxIndexConfig defines the configuration for the transaction indexer, | |||
| // including tags to index. | |||
| // including compositeKeys to index. | |||
There was a problem hiding this comment.
I think we'll need to explain what compositeKey is here:
Remember that Event have a following structure:
type: [
key: value,
...
]
composite key is a type and key, separated by a single dot. For example, given the Event below
"jack": [
"account.number": 100
]
composite key will be jack.account.number
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
melekes
reviewed
Dec 3, 2019
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
…t/tendermint into marko/rename-Tag-Event
melekes
reviewed
Dec 3, 2019
melekes
reviewed
Dec 3, 2019
melekes
approved these changes
Dec 3, 2019
|
we will need a changelog entry since we're breaking the config file (old config files won't work with new TM) |
melekes
reviewed
Dec 4, 2019
CHANGELOG_PENDING.md
Outdated
| @@ -70,14 +72,14 @@ program](https://hackerone.com/tendermint). | |||
| - Blockchain Protocol | |||
|
|
|||
| - [abci] \#2521 Remove `TotalTxs` and `NumTxs` from `Header` | |||
| - [types] [\#4151](https://github.com/tendermint/tendermint/pull/4151) Enforce ordering of votes in DuplicateVoteEvidence to be lexicographically sorted on BlockID | |||
| - [types][\#4151](https://github.com/tendermint/tendermint/pull/4151) Enforce ordering of votes in DuplicateVoteEvidence to be lexicographically sorted on BlockID | |||
There was a problem hiding this comment.
🤣 so I am adding white spaces and you're deleting them, nice
melekes
reviewed
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com