Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privval: remove previous protocol #5883

Closed
tac0turtle opened this issue Jan 11, 2021 · 2 comments
Closed

privval: remove previous protocol #5883

tac0turtle opened this issue Jan 11, 2021 · 2 comments
Labels
stale for use by stalebot T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:validator Type: Validator related
Projects
Tendermint Core Project Board
Milestone
v0.36

Comments

@tac0turtle
Copy link
Contributor

Summary

In preparation for 0.35 or later major release we should remove the previous/custom private validator protocol. (This is mainly deleting lines).
@tac0turtle tac0turtle added T:validator Type: Validator related T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Jan 11, 2021
@tac0turtle tac0turtle self-assigned this Jan 11, 2021
@tac0turtle tac0turtle mentioned this issue Jan 11, 2021
Merged
@tessr tessr added this to the v0.35 milestone Jan 11, 2021
@tessr tessr added this to Untriaged 🥚 in Tendermint Core Project Board via automation Jan 11, 2021
@tessr tessr moved this from Untriaged 🥚 to Icebox 🧊 in Tendermint Core Project Board Jan 11, 2021
@tac0turtle
Copy link
Contributor Author

Moving this to the next release cycle to keep in line with 0.35 be as non-breaking as possible.

@tac0turtle tac0turtle modified the milestones: v0.35, v0.36 Apr 30, 2021
@jackzampolin
Copy link
Contributor

Thank you for not killing it for this release, but I'm good with removing in 0.36

@jackzampolin jackzampolin mentioned this issue Jan 12, 2022
Closed
@tac0turtle tac0turtle removed their assignment Jan 13, 2022
@cmwaters cmwaters mentioned this issue Jan 13, 2022
Closed
1 task
@creachadair creachadair removed their assignment Jul 21, 2022
@github-actions github-actions bot added the stale for use by stalebot label Jul 25, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale for use by stalebot T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. T:validator Type: Validator related
Projects
No open projects
Tendermint Core Project Board
Icebox 🧊
Milestone
v0.36
Development

No branches or pull requests
4 participants
@creachadair @tessr @jackzampolin @tac0turtle