Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evidence: improve unit tests #5942

Closed
tessr opened this issue Jan 22, 2021 · 0 comments
Closed

evidence: improve unit tests #5942

tessr opened this issue Jan 22, 2021 · 0 comments
Assignees
Labels
C:evidence Component: Evidence stale for use by stalebot T:test Type: Tests that need love
Milestone

Comments

@tessr
Copy link
Contributor

tessr commented Jan 22, 2021

As part of our "evidence hardening" push, we should unit test the evidence reactor more thoroughly. Although the coverage numbers aren't terrible, it's mostly happy-path testing. (See https://codecov.io/gh/tendermint/tendermint/src/master/evidence/verify.go for a good example of this.) We should increase the unit tests to cover unhappy-paths and other error cases.

@tessr tessr added C:evidence Component: Evidence T:test Type: Tests that need love labels Jan 22, 2021
@tessr tessr added this to the v0.34.4 milestone Jan 22, 2021
@tessr tessr added this to Untriaged 🥚 in Tendermint Core Project Board via automation Jan 22, 2021
@tessr tessr moved this from Untriaged 🥚 to To Do 📝 in Tendermint Core Project Board Jan 22, 2021
@github-actions github-actions bot added the stale for use by stalebot label Jul 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:evidence Component: Evidence stale for use by stalebot T:test Type: Tests that need love
Projects
No open projects
Development

No branches or pull requests

2 participants