version: revert version through ldflag only #6494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6494 +/- ##
==========================================
- Coverage 61.02% 60.76% -0.27%
==========================================
Files 292 292
Lines 27319 27319
==========================================
- Hits 16672 16600 -72
- Misses 8953 9020 +67
- Partials 1694 1699 +5
|
tac0turtle
changed the title
tac0turtle
requested review from
alexanderbez,
cmwaters,
ebuchman,
tessr and
tychoish
as code owners
cmwaters
reviewed
May 27, 2021
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
cmwaters
reviewed
May 27, 2021
cmwaters
reviewed
May 27, 2021
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
|
@tessr as this mainly effects your work on releases, I'd like to get your sign off before merging. |
tessr
approved these changes
May 28, 2021
tac0turtle
added
S:backport-to-v0.34.x
tac0turtle
added a commit
that referenced
this pull request
May 28, 2021
Add version back to versions, but allow it to be overridden via a ldflag. Reason: Many users are not setting the ldflag causing issues with tooling that relies on it (cosmjs) closes #6488 cc @webmaster128
tac0turtle
added a commit
that referenced
this pull request
May 28, 2021
Add version back to versions, but allow it to be overridden via a ldflag. Reason: Many users are not setting the ldflag causing issues with tooling that relies on it (cosmjs) closes #6488 cc @webmaster128
tac0turtle
added a commit
that referenced
this pull request
May 31, 2021
* version: revert version through ldflag only (#6494) Add version back to versions, but allow it to be overridden via a ldflag. Reason: Many users are not setting the ldflag causing issues with tooling that relies on it (cosmjs) closes #6488 cc @webmaster128 * revert variable rename * Update CHANGELOG_PENDING.md
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add version back to versions, but allow it to be overridden via a ldflag.
Reason:
Many users are not setting the ldflag causing issues with tooling that relies on it (cosmjs)
closes #6488
cc @webmaster128