Backport the psql indexer into v0.34.x #6906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
requested review from
alexanderbez,
cmwaters,
ebuchman,
tessr,
tychoish and
williambanfield
as code owners
added 9 commits
September 7, 2021 06:21
The BackportTxIndexer and BackportBlockIndexer types implement the corresponding v0.34 indexing interfaces delegated to a psql EventSink. The implementations are trivial, but we need to delegate rather than surfacing another interface because the signatures overlap.
Also update test data to be type-compatible with the old protobuf types.
creachadair
force-pushed
the
mjf/psql-backport-paste
branch
from
b301c31
to
9740e5f
Compare
Codecov Report
@@ Coverage Diff @@
## v0.34.x #6906 +/- ##
==========================================
Coverage ? 61.51%
==========================================
Files ? 267
Lines ? 27918
Branches ? 0
==========================================
Hits ? 17173
Misses ? 9170
Partials ? 1575 |
tychoish
approved these changes
Sep 7, 2021
tac0turtle
approved these changes
Sep 7, 2021
Ah, good point, I didn't even think of that. Let me see about adding that to this PR. |
creachadair
force-pushed
the
mjf/psql-backport-paste
branch
from
ecc89b1
to
b8b7b4e
Compare
added 4 commits
September 7, 2021 11:48
Hopefully the newer analyzer will be smarter in later versions, but for now upgrading triggers a bunch of other issues with the older code.
This reverts commit 41b7182.
tychoish
approved these changes
Sep 7, 2021
|
|
creachadair
pushed a commit
that referenced
this pull request
Oct 4, 2021
iammadab
referenced
this pull request
in dashpay/tenderdash
Oct 24, 2021
This change backports the PostgreSQL indexing sink, addressing part of #6828. Development on the main branch has diverged substantially since the v0.34.x release. It includes package moves, breaking API and protobuf schema changes, and new APIs, all of which together have a large footprint on the mapping between the implementation at tip and the v0.34 release branch. To avoid the need to retrofit all of those improvements, this change works by injecting the new indexing sink into the existing (v0.34) indexing interfaces by delegation. This means the backport does _not_ pull in all the newer APIs for event handling, and thus has minimal impact on existing code written against the v0.34 package structure. This change includes the test for the `psql` implementation, and thus updates some Go module dependencies. Because it does not interact with any other types, however, I did not add any unit tests to other packages in this change. Related changes: * Update module dependencies for psql backport. * Update test data to be type-compatible with the old protobuf types. * Add config settings for the PostgreSQL indexer. * Clean up some linter settings. * Hook up the psql indexer in the node main. (cherry picked from commit 8ba6d21)
QuantumExplorer
referenced
this pull request
in dashpay/tenderdash
Oct 25, 2021
Backport the psql indexer into v0.34.x (#6906)
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change backports the PostgreSQL indexing sink, addressing part of #6828.
Development on the main branch has diverged substantially since the v0.34.x release. It includes package moves, breaking API and protobuf schema changes, and new APIs, all of which together have a large footprint on the mapping between the implementation at tip and the v0.34 release branch.
To avoid the need to retrofit all of those improvements, this change works by injecting the new indexing sink into the existing (v0.34) indexing interfaces by delegation. This means the backport does not pull in all the newer APIs for event handling, and thus has minimal impact on existing code written against the v0.34 package structure.
The high-level structure of this change is:
psqlindexing sink from tip, and modify it to remove dependencies on new APIs that are not being ported.psqlsink for the existingTxIndexerandBlockIndexertypes.psqlas an indexer type and to exposepsql-conn. I would have chosen a better name for this setting, but I thought it would be helpful to keep the same name we use at tip.psqlindexer to be selected.This change includes the test for the
psqlimplementation, and thus updates some Go module dependencies. However, because it does not interact with any other types, I did not add any unit tests to other packages in this change.