Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCI++: Synchronize ExtendVote and VerifyVoteExtension spec and implementation #7655

Closed
4 tasks
sergio-mena opened this issue Jan 21, 2022 · 0 comments · Fixed by #8141
Closed
4 tasks

ABCI++: Synchronize ExtendVote and VerifyVoteExtension spec and implementation #7655

sergio-mena opened this issue Jan 21, 2022 · 0 comments · Fixed by #8141
Assignees
Projects
Milestone

Comments

@sergio-mena
Copy link
Contributor

sergio-mena commented Jan 21, 2022

Summary

Synchronize ABCI++ interface APIs ExtendVote and VerifyVoteExtension in spec repo (v0.36 branch) with those in abci++ branch of the Tendermint Go repo.

Problem Definition

Once the protobufs are synchronized, we need to adapt the code in the consensus logic.

This issue depends on #7664 because we need to decide when to carry out this implementation.
If, in the end, it will land in 0.37, then we need to back out all VoteExension related PRs in the abci++ branch for v0.36

Dependencies


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@sergio-mena sergio-mena added this to To do in ABCI++ via automation Jan 21, 2022
@sergio-mena sergio-mena changed the title Synchronize ABCI++ protobufs for ExtendVote and VerifyVoteExtension ABCI++: Synchronize ExtendVote and VerifyVoteExtension spec and implementation Feb 2, 2022
@thanethomson thanethomson self-assigned this Feb 23, 2022
@thanethomson thanethomson moved this from To do to In progress in ABCI++ Mar 9, 2022
@sergio-mena sergio-mena moved this from In progress to Review in progress in ABCI++ Mar 22, 2022
@williambanfield williambanfield added this to the v0.36 milestone Mar 30, 2022
ABCI++ automation moved this from Review in progress to Done Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants