Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect from peer if it sends vote extension data when disabled #8565

Closed
Tracked by #9 ...
williambanfield opened this issue May 16, 2022 · 1 comment
Closed
Tracked by #9 ...
Labels
stale for use by stalebot

Comments

@williambanfield
Copy link
Contributor

Background

During the v0.36 development cycle, we implemented the ABCI++ VoteExtension feature. This feature could optionally be enabled by chains by selecting a height to require extensions. Before the selected height, vote extensions are not expected to be created or broadcast.

Proposal

A peer sending a vote extension before the configured height should be disconnected from. The peer is either running faulty and possibly malicious software.

@williambanfield williambanfield added this to To do in ABCI++ via automation May 16, 2022
@tychoish
Copy link
Contributor

I believe it's the case if the message handling function returns an error that the effect will be to disconnect the peer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale for use by stalebot
Projects
Status: Done/Merged
Development

No branches or pull requests

2 participants