cli: set node p2p external address with cmd flag #9107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amimart
requested review from
ebuchman,
cmwaters,
tychoish,
williambanfield,
creachadair,
sergio-mena,
jmalicevic,
thanethomson and
samricotta
as code owners
tychoish
approved these changes
Jul 27, 2022
|
Very interested in this feature to facilitate the deployment of our node in Kubernetes. 😊 |
amimart
force-pushed
the
cmd-add-p2p-external-address
branch
from
fb8cf32
to
9850d5c
Compare
|
I think this change can be included in the next release, on my side the backport branch is ready if accepted. If needed, I'd be happy to discuss about the relevance of this change, I may not see the trade-offs it could bring. |
|
Hey @amimart, thanks for opening the PR. Do you mind basing this against I can handle the backport into v0.34 |
amimart
force-pushed
the
cmd-add-p2p-external-address
branch
from
9850d5c
to
5ff9ac8
Compare
cmwaters
approved these changes
Aug 1, 2022
amimart
force-pushed
the
cmd-add-p2p-external-address
branch
from
5ff9ac8
to
c33a555
Compare
|
I think you need to update to the |
amimart
force-pushed
the
cmd-add-p2p-external-address
branch
from
c33a555
to
254d96e
Compare
amimart
force-pushed
the
cmd-add-p2p-external-address
branch
from
1cdb9d6
to
aacec75
Compare
samricotta
pushed a commit
that referenced
this pull request
Aug 1, 2022
Closes #9035 Add the `p2p.external-address` command line argument to configure the node external address.
cmwaters
pushed a commit
that referenced
this pull request
Aug 2, 2022
Closes #9035 Add the `p2p.external-address` command line argument to configure the node external address.
tychoish
pushed a commit
that referenced
this pull request
Aug 2, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 12, 2022
Closes #9035 Add the `p2p.external-address` command line argument to configure the node external address.
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
Closes #9035 Add the `p2p.external-address` command line argument to configure the node external address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9035
Add the
p2p.external-addresscommand line argument to configure the node external address.