Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: Define a specification #9573

Closed
Tracked by #9321
thanethomson opened this issue Oct 17, 2022 · 0 comments
Closed
Tracked by #9321

p2p: Define a specification #9573

thanethomson opened this issue Oct 17, 2022 · 0 comments
Assignees
Labels
C:p2p Component: P2P pkg stale for use by stalebot

Comments

@thanethomson
Copy link
Contributor

thanethomson commented Oct 17, 2022

This follows from #9089.

We want to ensure that our P2P layer implementation is correct. Given that all we have at present (v0.37, v0.34 and earlier versions) is an implementation, without a specification (i.e. a definition of how the P2P layer should work), it makes it hard to understand and test.

To this end, we believe we need to develop (i.e. invent) a specification for the P2P layer, using whatever relevant learnings we've picked up from our prior work in documenting how the v0.34 P2P layer works. This can also be informed by ADR-061 and ADR-062. This need not apply to the entire P2P layer - only those parts that can possibly be specified.

Follow-up work to this will include refactoring of the P2P layer to conform to the specification we develop here.

@thanethomson thanethomson added the C:p2p Component: P2P pkg label Oct 17, 2022
This was referenced Oct 17, 2022
@thanethomson thanethomson added the priority A high-priority, high-level item to be shown on the priorities project board label Oct 17, 2022
@josef-widder josef-widder self-assigned this Nov 11, 2022
@thanethomson thanethomson removed the priority A high-priority, high-level item to be shown on the priorities project board label Dec 22, 2022
@github-actions github-actions bot added the stale for use by stalebot label Feb 16, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:p2p Component: P2P pkg stale for use by stalebot
Projects
Status: Done/Merged
Development

No branches or pull requests

2 participants