Skip to content
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.

Implement SocketDB #203

Closed
cwgoes opened this issue Apr 24, 2018 · 5 comments
Closed

Implement SocketDB #203

cwgoes opened this issue Apr 24, 2018 · 5 comments
Assignees

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Apr 24, 2018

From conversation with @jaekwon -

jaekwon - btw we also need to create a socket version of DB so we can connect an external DB… SocketDB.
maybe using GRPC or something.  lmk if you have time to work on it.

cwgoes
I can probably work on SocketDB next week, did you have a particular gRPC interface in mind / should SocketDB include "socketDB server" which interfaces to a local non-socket DB?

jaekwon
yes, and we just need to support CLevelDB there for now.
i don’t have a particular gRPC interface in mind.  I wonder if someone’s already done this work.
it also needs security so we need to be able to do a TLS handshake first… or use secret_connection.
@cwgoes cwgoes self-assigned this Apr 24, 2018
@ebuchman
Copy link
Contributor

Looks like Odeke started working on this in #162.

Theres also already an issue for this in tendermint/tendermint#1162

I suppose we can close that one and let this one track.

@odeke-em
Copy link
Contributor

@ebuchman in deed :)

Please feel free to take over it @cwgoes and @ebuchman: my PR allows for authentication and it is over gRPC both with single and bidirectional streaming -- I believe it satisfies all the requested requirements from @jaekwon and @ebuchman, but perhaps could even be tweaked further

@cwgoes
Copy link
Contributor Author

cwgoes commented May 7, 2018

To be added: secure transport layer (helpful guide).

@cwgoes
Copy link
Contributor Author

cwgoes commented May 7, 2018

Do we want batch operations? Presumably...

Also, do we want any kind of automatic certificate generation, or is it fine to delegate that to library users?

@cwgoes
Copy link
Contributor Author

cwgoes commented May 10, 2018

Closed by #162. Still going to attempt CLevelDB deterministic builds.

@cwgoes cwgoes closed this as completed May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants