Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Basque and Spanish metadata, tiny corrections on strings and improved Readme #37

Closed
wants to merge 5 commits into from

Conversation

Porrumentzio
Copy link
Contributor

I didn't add new screenshots, but I propose you to add some of the use on Share menu, some with the notification and some about the in-app settings.
This way it would be more attractive (and it will appear more on F-Droid, as they give preference to content with metadata)

@Porrumentzio
Copy link
Contributor Author

I now added an explanation about translating metadata, on the Contributing part on the README.

@Porrumentzio Porrumentzio changed the title Added Basque and Spanish metadata and tiny corrections on strings Added Basque and Spanish metadata, tiny corrections on strings and improved Readme Aug 15, 2020
@tasn
Copy link
Member

tasn commented Aug 16, 2020

README: awesome!
Could you please get rid of the merge commit and instead rebase on top of master? We try to maintain a linear history in this repo.

Thanks!

@Porrumentzio
Copy link
Contributor Author

I don't know much about git, so I had to read this explanation: https://www.atlassian.com/git/tutorials/merging-vs-rebasing

I'll try to rebase it and after, PR.
Wish me luck haha

@tasn
Copy link
Member

tasn commented Aug 17, 2020

Haha, git is an important tool to any developer, learning how to use it better will surely save you time in the long run!

@Porrumentzio
Copy link
Contributor Author

Yes, I know. Although, the main thing is that I'm not a developer, but a simple translator :)
But yes, I'm learning git little by little

@tasn
Copy link
Member

tasn commented Aug 17, 2020

So let's not waste your time! It's not your fault we don't have a proper translation system set up. :|

@Porrumentzio
Copy link
Contributor Author

Nah, the translation are so tiny to build a system (Weblate, Crowdin...). And all was okay with the translation. The thing is that I don't know git enough to make rebases and so, but it's easy with a simple merge commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants