Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add other arities for IFn protocol #65

Open
pfeodrippe opened this issue May 14, 2022 · 4 comments
Open

Add other arities for IFn protocol #65

pfeodrippe opened this issue May 14, 2022 · 4 comments

Comments

@pfeodrippe
Copy link
Contributor

pfeodrippe commented May 14, 2022 •
edited

Add other arities for IFn protocol as we have in Clojure and Clojurescript.

Is there some limitation in Dart for it? If there is not, I can open a PR for it o/
@pfeodrippe pfeodrippe changed the title Add until 21 arity function for IFn Add other arities for IFn protocol May 14, 2022
@D00mch D00mch mentioned this issue May 14, 2022
Open
@cgrand
Copy link
Contributor

cgrand commented May 17, 2022 •
edited

There's no limitation but is there any strong reason to align?
Is there a strong case of existing cljc code whose performance would degrade if the threshold is at 10 rather than 20?

@pfeodrippe
Copy link
Contributor Author

pfeodrippe commented May 17, 2022 •
edited

There's no limitation but is there any strong reason to align? Is there a strong case of existing cljc code whose performance would degrade if the threshold is at 10 rather than 20?

It's not for performance, it's to make it work with SCI (or other libraries which implement IFn in full)
without having to creating special cases for it, e.g. https://github.com/babashka/sci/blob/1dc44b30044e387c0069bc051a511d6fc889f3f1/src/sci/impl/vars.cljc#L326

I can open the PR tonight if you want, thanks for the great job you both are doing o/

@cgrand
Copy link
Contributor

cgrand commented May 20, 2022

ok, I will review your pr

@cgrand cgrand added the good first issue Good for newcomers label Jun 8, 2022
ruseel pushed a commit to ruseel/ClojureDart that referenced this issue Sep 28, 2022
Add other arities for IFn protocol Tensegritics#65
7e71367
@ruseel ruseel mentioned this issue Sep 28, 2022
Closed
@ruseel
Copy link
Contributor

ruseel commented Oct 26, 2022

Maybe.. this is not a good first issue. I tried very naive PR in #65.

@cgrand cgrand removed the good first issue Good for newcomers label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgrand @ruseel @pfeodrippe