Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new MCT item: DATADISPLAYLIST #1

Open
tensfeldt opened this issue Nov 1, 2019 · 1 comment
Open

new MCT item: DATADISPLAYLIST #1

tensfeldt opened this issue Nov 1, 2019 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@tensfeldt
Copy link
Owner

@Rudraya, Currently, MCT includes PARAMETERDISPLAYLIST which, out of necessity is required to include the parameters to return for a virtual compute call (i.e. parameterset argument == "PARAMETERDISPLAYLIST") AS WELL AS any data items from the input dataset needed to display in the KEL parameter results pane in the Application Analysis module.

In order to separate the DATA items from the computation engine PARAMETER result items being displayed in the Application Analysis Module a new MCT entry is being introduced with openNCA 2.0.1, the DATADISPLAYLIST.

DATADISPLAYLIST will contain data field names from the input dataset required to display in the KEL parameter results pane in the application and now the PARAMETERDISPLAYLIST will only have names of the parameters required.

It is considered that the virtual compute call wrapper script can be updated to manage changes in openNCA 2.0.1 that are required for this without modification to the compute engine code itself but this issue is entered for awareness and to consider the implications in more depth as development proceeds with openNCA CE 2.0.1. If modifications are required to the wrapper script that calls the compute engine for virtual compute calls, these will be done separately from the work being pursued by @Rudraya .

@jhhughes256 jhhughes256 added the documentation Improvements or additions to documentation label Nov 21, 2019
@tensfeldt
Copy link
Owner Author

As discussed at the 2019-12-19 Checkpoint session, the following behavior is what is required for incorporation of "DATADISPLAYLIST" in the MCT

  1. If parameterset == "PARAMETERDISPLAYLIST" (virtual compute call in openNCA application)
  • PARAMETERDISPLAYLIST is the list of parameter names representing the parameters to be computed and delivered to the output results from run_computation
  • DATADISPLAYLIST is a list of input concentration column names to be merged into the output results from run_computation
  1. If parameterset == "PARAMETERLIST" (non-virtual or save analysis compute call in openNCA application)
  • PARAMETERLIST is the list of parameter names representing the parameters to be computed and delivered to the output results from run_computation
  • RETURNCOLS is a list of input concentration column names to be merged into the output results from run_computation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants