Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-04-02 tc1572 M4SS - CONC and CONCTIME, parameter outputs not provided in results from run_computation #202

Closed
TomTensfeldt opened this issue Apr 2, 2020 · 3 comments
Labels
3.0 defect Defect identified during code development for Computation Engine v3.0

Comments

@TomTensfeldt
Copy link
Collaborator

  • datasets provided in onedrive repository
    for M4SS executions, no CONC or CONCTIME outputs are provided.
@jhhughes256
Copy link
Collaborator

As of commit cca452d this issue no longer occurs. Output for tc1572 shown below.

r[,c(grep("^SDEID$", names(r)), grep("^CON.+\\d+$", names(r)))]
       SDEID CONC1 CONCTIME1
1  661083556  9310         0
2  737250770  9230         0
3 1723871653  8280         0
4 2187657022  9970         0
5 2432717605  6170         0
6 3854759896  6450         0

@jhhughes256
Copy link
Collaborator

jhhughes256 commented Sep 2, 2020

I've been informed that this is the opposite behaviour than intended, and that CONCi and CONCTIMEi were to be removed from the M4 methods. @TomTensfeldt please close this issue if I have misinterpreted your correspondence on this, alternatively we may need to edit this issue to capture the change in issue scope.

@jhhughes256 jhhughes256 reopened this Sep 2, 2020
@jhhughes256 jhhughes256 added the 3.0 defect Defect identified during code development for Computation Engine v3.0 label Sep 2, 2020
@jhhughes256
Copy link
Collaborator

As of commit 472a0a2 CONC1 and CONCTIME1 are no longer present in the computation engine output.

r[,c(grep("^SDEID$", names(r)), grep("^CON", names(r)))]
       SDEID CONCU CONCNORMU
1  661083556 NG/ML        NA
2  737250770 NG/ML        NA
3 1723871653 NG/ML        NA
4 2187657022 NG/ML        NA
5 2432717605 NG/ML        NA
6 3854759896 NG/ML        NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 defect Defect identified during code development for Computation Engine v3.0
Projects
None yet
Development

No branches or pull requests

2 participants