2020-05-12 tc1518_M4SS TLAG incorrectly computed

[TomTensfeldt]

TLAG isn't correct for this M4 SS model execution. Reported as 6 hours but should be "0". Note, as per the Definitions of TLAG in Sections Section 8.2.1 and 8.2.2, "If all concentrations have a value greater than 0 then TLAG is 0." .

[jhhughes256]

Linking this to #199, #220, #221

[TomTensfeldt]

This also occurs with test case tc1572_M4SS.

[jhhughes256]

As of commit cca452d this issue has been resolved. This issue can now be closed.

The following is an excerpt from tc1518_M4SS_cca452d.html

Add and compare TLAG parameter

Note, as per the Definitions of TLAG in Sections Section 8.2.1 and 8.2.2, “If all concentrations have a value greater than 0 then TLAG is 0.”

for(i in unique(refparams[,mct$SDEID])) {
  k <- refparams[,mct$SDEID]==i
  # this won't work if there are "trailing" zeros ######################################################################
  m <- (refparams[k,rateincrements]==0)
  maxnz <- max(refparams[k,paste0("MIDPT", 1:ntimepoints)][!m])
  print(maxnz)
  if(any(m)) {
    refparams$TLAG[k] <- max(refparams[k,paste0("MIDPT", 1:ntimepoints)][m])
  }
  else {
    refparams$TLAG[k] <- 0
  }
}
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18
## [1] 18

Compare TLAG parameter

clist <- compare_parameters("TLAG$", alist=assessedparameters, ref.params=refparams, tst.params=results, tol=tolerance)
## testing TLAG vs TLAG 
## Equal
if(length(clist$n.ref)>0 & length(clist$n.tst)>0) assessedparameters <- remove1(assessedparameters, clist$rname)