Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable buildkit merge op when using moby builder #1693

Closed
kemingy opened this issue Jul 7, 2023 · 2 comments · Fixed by #1699
Closed

feat: disable buildkit merge op when using moby builder #1693

kemingy opened this issue Jul 7, 2023 · 2 comments · Fixed by #1699
Labels
type/feature 💡

Comments

@kemingy
Copy link
Member

kemingy commented Jul 7, 2023

Describe the feature

Currently, we use docker instead of moby builder because #1547.

The downside is that we need to convert the image type which may take a long time for large CUDA-based images.

A possible solution is to disable the merge op when using moby builder.

Currently, merge op is used by:

  • system package & language installation
  • extra HTTP sources (rare)
  • language packages (when the build has multiple languages, i.e. python + r) (rare)

Why do you need this feature?

No response

Additional context

No response
@gaocegege
Copy link
Member

cc @pingsutw

@pingsutw
Copy link
Member

pingsutw commented Jul 7, 2023 •
edited

thanks, Let me know once you open a pr. I can test it

@kemingy kemingy mentioned this issue Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v1): disable diff/merge op for moby builder kemingy/envd
3 participants
@gaocegege @kemingy @pingsutw