-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tech-debt(ssh): Hard-coded midi-ssh #48
Comments
How about https://github.com/tensorchord/MIDI/blob/main/pkg/remote/ssh/key.go#L3 ? Is it also used as a hard-coded string? |
@gaocegege Where does this come from? And where's the public key? |
I do not know. I will dive into the code. |
#dibs |
I think we can deliver the binary in the Github release, then download the binary there instead of using the one in bin/ It can be cached in the ~/.midi/cache. |
I will open a new issue to keep track of the key problem. The hard coded ssh binary is removed in #73 |
The default ssh download URL is not always public, we need to use the public URL. And we should not hard code the version. |
Currently the SSH is hard-coded at examples/ssh_keypairs. We may need to make it flexible to configure.
The text was updated successfully, but these errors were encountered: