Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt(ssh): Hard-coded midi-ssh #48

Closed
VoVAllen opened this issue Apr 23, 2022 · 7 comments · Fixed by #80
Closed

tech-debt(ssh): Hard-coded midi-ssh #48

VoVAllen opened this issue Apr 23, 2022 · 7 comments · Fixed by #80

Comments

@VoVAllen
Copy link
Member

Currently the SSH is hard-coded at examples/ssh_keypairs. We may need to make it flexible to configure.

@gaocegege
Copy link
Member

How about https://github.com/tensorchord/MIDI/blob/main/pkg/remote/ssh/key.go#L3 ? Is it also used as a hard-coded string?

@VoVAllen
Copy link
Member Author

VoVAllen commented Apr 24, 2022

@gaocegege Where does this come from? And where's the public key?

@gaocegege
Copy link
Member

I do not know. I will dive into the code.

@gaocegege gaocegege changed the title tech-debt(ssh): Hard-coded SSH key tech-debt(ssh): Hard-coded SSH key and midi-ssh Apr 24, 2022
@gaocegege gaocegege self-assigned this Apr 25, 2022
@gaocegege
Copy link
Member

#dibs

@gaocegege
Copy link
Member

I think we can deliver the binary in the Github release, then download the binary there instead of using the one in bin/

It can be cached in the ~/.midi/cache.

@gaocegege gaocegege changed the title tech-debt(ssh): Hard-coded SSH key and midi-ssh tech-debt(ssh): Hard-coded midi-ssh Apr 27, 2022
@gaocegege
Copy link
Member

I will open a new issue to keep track of the key problem. The hard coded ssh binary is removed in #73

@gaocegege
Copy link
Member

The default ssh download URL is not always public, we need to use the public URL. And we should not hard code the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants