Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-conformant date string in API response #45

Closed
manikmakki opened this issue Sep 15, 2023 · 1 comment · Fixed by #46
Closed

Non-conformant date string in API response #45

manikmakki opened this issue Sep 15, 2023 · 1 comment · Fixed by #46

Comments

@manikmakki
Copy link
Contributor

Hello! While attempting to integrate https://github.com/tensorchord/modelz-llm with a project, I discovered that the two following references are not conformant with the OpenAI API spec and are causing errors when the external application attempts to parse the response from the API.

https://github.com/tensorchord/llmspec/blob/088cd31fab8eef9ecc2cd36c0922d21128413471/llmspec/llmspec.py#L124C1-L125C1
https://github.com/tensorchord/llmspec/blob/088cd31fab8eef9ecc2cd36c0922d21128413471/llmspec/llmspec.py#L156C14-L156C14

For reference, the OpenAI API Reference states that the "created" value is a Unix Timestamp in seconds when in reality is more commonly known as "epoch milliseconds".

@manikmakki
Copy link
Contributor Author

Additionally, my mistake, the function I proposed converts milliseconds to seconds, per the OpenAI API Reference.

@kemingy kemingy linked a pull request Sep 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant