Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfa.losses.GIoULoss docs not clear about input format #2846

Closed
VachanVY opened this issue Aug 4, 2023 · 2 comments
Closed

tfa.losses.GIoULoss docs not clear about input format #2846

VachanVY opened this issue Aug 4, 2023 · 2 comments

Comments

@VachanVY
Copy link

VachanVY commented Aug 4, 2023

The bounding box input format is unclear in GIoULoss. Please include in which format the boxes should be in the docs.

As per the source code

Args:
y_true: true targets tensor. The coordinates of the each bounding
box in boxes are encoded as [y_min, x_min, y_max, x_max].
y_pred: predictions tensor. The coordinates of the each bounding
box in boxes are encoded as [y_min, x_min, y_max, x_max].
mode: one of ['giou', 'iou'], decided to calculate GIoU or IoU loss.

include the above in docs

@coder-amey
Copy link

I am stuck here as well. The source code implies that the designated format is min-max, with y before x, which is quite unusual. With addons getting deprecated, I am not certain if we will obtain any clarity on this.

@VachanVY
Copy link
Author

VachanVY commented Nov 1, 2023

@coder-amey In many keras tutorials, they use box util functions like swap_xy, may be that's a Tensorflow-keras thing. Go according to the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants