Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you accept tf.keras.callbacks? #58

Closed
beangoben opened this issue Feb 26, 2019 · 6 comments
Closed

Do you accept tf.keras.callbacks? #58

beangoben opened this issue Feb 26, 2019 · 6 comments

Comments

@beangoben
Copy link

Seeing as keras is going to become a first citizen inside of tensorflow, are you also accepting submission for callbacks? Are there guidelines for this (writing tests/docs)?.

@seanpmorgan
Copy link
Member

My first thought is that it seems like it would be in scope as there is a pre-defined structure. I'll add it to the monthly meeting this Friday where we can discuss adding this as a new standardized API.

I'll update this issue after the meeting... but can you give some example callbacks you'd like to see added and/or would be willing to contribute?

@seanpmorgan
Copy link
Member

Also, just a reminder... the monthly meeting is at 1pm PST (join our google group and you'll get calendar invites) and we encourage all to come!

@beangoben
Copy link
Author

Would have to check, but potentially some callbacks would be:

@facaiy
Copy link
Member

facaiy commented Feb 27, 2019

Do you mean to implement them as subclass of tf.keras.callbacks.Callback?

@beangoben
Copy link
Author

Yes, with tests..but that all depends on the guidelines that will be recommended/set.

@seanpmorgan
Copy link
Member

Short answer to this issue is Yes. See #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants