Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DenseToSparse #8

Closed
seanpmorgan opened this issue Jan 12, 2019 · 2 comments
Closed

Implement DenseToSparse #8

seanpmorgan opened this issue Jan 12, 2019 · 2 comments
Labels
discussion needed help wanted Needs help as a contribution layers

Comments

@seanpmorgan
Copy link
Member

seanpmorgan commented Jan 12, 2019 •
edited

Per the RFC, we need to move dense_to_sparse from contrib to addons:

This will involve restructuring in an OO format by inheriting from base Keras Layer, modifying the code to match those APIs, and modifying test cases to run in TF2.

Discussion: Does it make more sense to consider this a low level nn block instead of a Layer? Or just an array op?
@seanpmorgan seanpmorgan added help wanted Needs help as a contribution layers labels Jan 12, 2019
@seanpmorgan
Copy link
Member Author

tensorflow/tensorflow#23754 is a relevant discussion regarding a more efficient way to do this using cusparse

@seanpmorgan
Copy link
Member Author

seanpmorgan commented Jul 9, 2019 •
edited

After some discussion we'll be closing this issue pending community outreach in support for it. It has no OSS usage as far as we can see and it may not neatly fit into our subpackages

@breadbread1984 breadbread1984 mentioned this issue Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion needed help wanted Needs help as a contribution layers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seanpmorgan