Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all test_mnist_tutorial_*.py #167

Closed
carlini opened this issue Jun 9, 2017 · 3 comments
Closed

Remove all test_mnist_tutorial_*.py #167

carlini opened this issue Jun 9, 2017 · 3 comments

Comments

@carlini
Copy link
Collaborator

carlini commented Jun 9, 2017

These tests are really slow to run, flakey, and should be replaced by unit tests of each individual method.

@goodfeli
Copy link
Contributor

goodfeli commented Jun 9, 2017

I think they should be sped up, rather than removed. They're the only thing we have resembling an integration test. Integration tests are important as well as unit tests.

@goodfeli
Copy link
Contributor

goodfeli commented Jun 9, 2017

Also, before we had the tests, people routinely made edits to the tutorials themselves that broke the tutorials.

@npapernot
Copy link
Member

Given that #155 cut testing time to about 12mn, I'm going to close this for now. Once unit test have a better coverage of the code base, we can decrease the test time even more by further reducing the problem size of tutorial tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants