Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included FAQ page to the Navigation #4106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Included FAQ page to the Navigation #4106

wants to merge 4 commits into from

Conversation

Barathwaja
Copy link

Updated the book.yaml to include FAQ Page. Please review.

@Barathwaja
Included FAQ page to the Navigation
7c6c248 
Updated the book.yaml to include FAQ Page.
@Barathwaja Barathwaja mentioned this pull request Aug 31, 2023
Open
zcharles8
zcharles8 requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@zcharles8 zcharles8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the Guide section instead? I think that's more appropriate.

Also we're having a bit of difficulty in automatically merging PRs at this time, so apologies for the delay in reviewing / acting on PRs right now.

@Barathwaja
Copy link
Author

Hi @zcharles8 ,

No problem. :)

I Just updated the branch and shifted the link under "Guide". Can you check it out?

Thanks!

zcharles8
zcharles8 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@zcharles8 zcharles8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merging is going to take a bit longer than I'd like due to some weird issues on our end, but thank you for looking into this!

@Barathwaja
Copy link
Author

@zcharles8 . Sure no problem. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcharles8 zcharles8 zcharles8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Barathwaja @zcharles8