Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaskGradients doc string error #57

Closed
zh794390558 opened this issue Mar 28, 2019 · 3 comments
Closed

MaskGradients doc string error #57

zh794390558 opened this issue Mar 28, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@zh794390558
Copy link
Contributor

https://github.com/tensorflow/lingvo/blob/master/lingvo/core/py_utils.py#L1381

The docstring of function def MaskGradients(var_grad, grad_mask, grad_onehot) is wrong, and I do not know the function of this method.
@jonathanasdf
Copy link
Contributor

I think it is almost right, but grad_mask should be (variable_name, mask). Is that what you mean?

@drpngx drpngx added the stat:awaiting response Awaiting response from user label Mar 29, 2019
@zh794390558
Copy link
Contributor Author

Yes, but Computes gradients of variables in vmap w.r.t. loss. does it right? It is same to ComputeGradients, and I think this method is not for computing gradients.

@jonathanasdf
Copy link
Contributor

Ah, I see what you mean now. Will look into it.

@jonathanasdf jonathanasdf added bug Something isn't working and removed stat:awaiting response Awaiting response from user labels Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanasdf @zh794390558 @drpngx