Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Add code linting reporter? #12

Closed
ludwigschubert opened this issue Feb 2, 2018 · 1 comment
Closed

Add code linting reporter? #12

ludwigschubert opened this issue Feb 2, 2018 · 1 comment

Comments

@ludwigschubert
Copy link
Contributor

I am considering adding a code quality reporter once we're a public repo.

The main objection would be that its extra work to configure + we may not always agree with default stylistic choices. For example, most linters will flag our usage of the T function as (technically correct) unidiomatic.

Leaving this here for discussion, @colah @znah. :-)

@ludwigschubert ludwigschubert added enhancement New feature or request infrastructure and removed enhancement New feature or request labels Feb 2, 2018
@ludwigschubert ludwigschubert changed the title Add code quality reporter? Add code linting reporter? Feb 7, 2018
@ludwigschubert
Copy link
Contributor Author

ludwigschubert commented Feb 9, 2018

Deciding not to do this for now as it seems a little late once a commit is pushed. Encouraging linter use in your local editor instead. We may consider adding a more sophisticated code quality report metric later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant