Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export STFT? #393

Closed
deltonvaz opened this issue Jan 14, 2020 · 2 comments
Closed

Export STFT? #393

deltonvaz opened this issue Jan 14, 2020 · 2 comments

Comments

@deltonvaz
Copy link

deltonvaz commented Jan 14, 2020

Hello!

I have a project and I need to use the Short Term Fourier Transform directly but I noticed that despite being the documentation I cannot use it. Would it be possible to export the function so that it could be used? Or is there another way to access it that I'm not seeing?

Thanks õ/

@notwaldorf
Copy link
Collaborator

Oh yeah, I think we can do that! Going to send a PR out today

@notwaldorf
Copy link
Collaborator

Alright, I've thought about this more and I don't think we want to add all these audio_utils as a public API -- we added them for a model in particular, and the problem is that they aren't tested for all cases. We definitely don't plan on working on them or adding new features, and there's many libraries out there that give you different ways to do stfts. So this is why I think they should remain a private API.

I'm not exactly sure why the documentation is being generated for them (I assume it's a bug with the docs generator), but I think your best bet if you want to use this particular stft implementation is to just copy it into your own project from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants