Add Python3 support to midi_hub and fix tests. #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cghawthorne
approved these changes
Mar 20, 2018
| @@ -345,7 +345,7 @@ def testStartCapture_IsDrum(self): | |||
| captor = self.midi_hub.start_capture(120, start_time) | |||
|
|
|||
| # Channels are 0-indexed in mido. | |||
There was a problem hiding this comment.
is this comment still true?
There was a problem hiding this comment.
Yes, I just thought the one-indexed drum channel was 9 when it is actually 10.
CosmosHua
pushed a commit
to CosmosHua/magenta
that referenced
this pull request
Jul 20, 2018
* Add Python3 support to midi_hub and fix tests. * pip3 compat * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.