Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing test case after remove disc #32

Closed
lipracer opened this issue Mar 9, 2022 · 5 comments
Closed

missing test case after remove disc #32

lipracer opened this issue Mar 9, 2022 · 5 comments

Comments

@lipracer
Copy link
Contributor

lipracer commented Mar 9, 2022

Would we remove this file mhlo_fusion.cc ?
@burmako
Copy link
Contributor

burmako commented Mar 9, 2022

Thank you for the ticket! Indeed, this pass is unused now after the recent removal of DISC from the repo. We'll clean this up shortly.

@lipracer
Copy link
Contributor Author

Are upstream or downstream dependent on this pass? If not, I can remove it.

@burmako
Copy link
Contributor

burmako commented Mar 10, 2022

Earlier today, @joker-eph has put together a patch in our internal code review system, so I expect that it'll land soon and will get propagated back to GitHub. Thank you for your kind offer though :)

@lipracer
Copy link
Contributor Author

Thanks.

@joker-eph
Copy link
Contributor

Pushed in 74ca70f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@burmako @joker-eph @lipracer