-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake build] MhloDialect target no longer carries correct binary include dir #57
Comments
Hi @christopherbate! Thank you for reporting. |
Thanks for bringing this to my attention! @christopherbate can you let me know if d391887 fixes this? |
@ddunl Thanks for your response. This actually doesn't fix it (in LLVM External Project mode). I added a print statement like this:
and |
Ah I was clearly not being careful enough when I made that change. I'll test a fix more thoroughly tomorrow. So sorry this is taking so long to get resolved! |
Woops, didn't intend for this to be closed. Let me know if a170d81 fixes this. I had a hard time finding a project using LLVM External Project mode, but I was able to replicate the faulty path using that |
After this latest change to mlir-hlo/mhlo/CMakeLists.txt, the MhloDialect target no longer has the correct binary include directories attached to its INTERFACE_INCLUDE_DIRECTORIES. I now have to do the following in my downstream project when building
mlir-hlo
via the "LLVM External Project" route:Otherwise, the build will fail on downstream targets that depend on
MhloDialect
. The compiler will say:Note that this is different from #52 (which probably can now be closed).
Edit: fixed the workaround
The text was updated successfully, but these errors were encountered: