Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Setuptools Instead of Distutil for Build Command #55

Closed

Conversation

jhamet93
Copy link

@jhamet93 jhamet93 commented Oct 1, 2019

Referencing this issue: #50. We ran into the exact same issue not allowing the extension to be enabled in the notebook. When installing the extension, the static directory is looked up relative to the package location. When building a binary distribution, no static directory was created relative to the tensorflow_model_analysis package location.

To reproduce prior:

python setup.py bdist_wheel
unzip -l tensorflow_model_analysis-0.15.0.dev0-py2-none-any.whl | grep "tensorflow_model_analysis/static/*.js"

Using setuptools instead of distutils resolved the issue.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jhamet93
Copy link
Author

jhamet93 commented Oct 1, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kwlzn
Copy link

kwlzn commented Oct 25, 2019

@mdreves would you be able to help us get this merged and released?

@mdreves mdreves self-requested a review October 25, 2019 17:51
@mdreves mdreves self-assigned this Oct 25, 2019
tfx-copybara pushed a commit that referenced this pull request Oct 25, 2019
PiperOrigin-RevId: 276771947
@mdreves
Copy link
Member

mdreves commented Oct 25, 2019

Updated manually after copybara failed. This should be in the next release.

@mdreves mdreves closed this Oct 25, 2019
@kwlzn
Copy link

kwlzn commented Oct 25, 2019

thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants