Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise error if tfp.layers' kernel_prior/posterior aren't specified with correct shapes #29

Open
dustinvtran opened this issue Apr 27, 2018 · 2 comments

Comments

@dustinvtran
Copy link
Member

dustinvtran commented Apr 27, 2018

A common user mistake is to specify the kernel_prior or kernel_posterior distribution without a matrix event shape. This makes the KL divergence computation incorrect as the KL must be over matrixvariate distributions. Let's catch this early on by checking during build().

Same applies to bias vector.

@LexusH
Copy link

LexusH commented Feb 15, 2020

Hello, I'm new to this project and would love to help with your recommended changes. Any guidance on this topic would be much appreciated, but I will go digging around in the files you brought up immediately to see if I can fix this!

@LexusH
Copy link

LexusH commented Feb 18, 2020

I have a small demo up to try and test the error you're mentioning, but I don't think I understand what output method to be using to see your error. I'd love to get your input on what i'm doing wrong here:
https://colab.research.google.com/drive/1qhKpW5FdD0bHvE6BOjoT5_hU7kkL6A_J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants