Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo in line 218, sgld.py #50

Closed
ylfzr opened this issue May 23, 2018 · 3 comments
Closed

Small typo in line 218, sgld.py #50

ylfzr opened this issue May 23, 2018 · 3 comments

Comments

@ylfzr
Copy link

ylfzr commented May 23, 2018

Hi team,

I think the injected noise in line 218, sgld.py should be:

tf.random_normal(tf.shape(grad), 0., 1., dtype=grad.dtype) * stddev * tf.sqrt(preconditioner)

, rather than

tf.random_normal(tf.shape(grad), 1., dtype=grad.dtype) * stddev * tf.sqrt(preconditioner) 

right?
Or am I missed something?

@cyrilchim
Copy link

Hi! Thanks for reaching out. You are right. We expect to have a fix done in O(days).

@cyrilchim
Copy link

Hope it is still relevant, SGLD is now fixed!

@dustinvtran
Copy link
Member

Marking fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants