Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick breaking bijector #6

Closed
dustinvtran opened this issue Mar 29, 2018 · 7 comments
Closed

Stick breaking bijector #6

dustinvtran opened this issue Mar 29, 2018 · 7 comments
Assignees

Comments

@dustinvtran
Copy link
Member

Motivated by conversation in probtorch/pytorch#112

@junpenglao
Copy link
Contributor

Is bijector going to be merged into tensorflow/probability? or contribution should be submitted directly to tensorflow?

@srvasude
Copy link
Member

Hi Junpeng,
As of this moment bijectors and distributions are living in core tensorflow. However, in the future I think we would like to move these over here. Contributions can continue to go to tensorflow, and hopefully in the near future they will all be moved here.

I also believe tfp.distributions should work (vs. tf.contrib.distributions), so contributing to core tensorflow still allows you to use the tensorflow_probability namespace :).

@dustinvtran
Copy link
Member Author

@srvasude: Are you working on this? Otherwise, do you think this is a "good first issue" to label for external contributors?

@srvasude
Copy link
Member

I'm not actively working on this (but might get to at some point). This could be a good first issue (although there are nuances to stick breaking. The ordered bijector might be a better "good first issue").

@dustinvtran
Copy link
Member Author

Got it. I'll leave you as assigned for this one and label the ordered bijector as "good first issue".

@twiecki
Copy link

twiecki commented Mar 4, 2019

Any progress on this? This is a fairly important bijector.

@srvasude
Copy link
Member

srvasude commented Mar 4, 2019

I recently wrote an internal PR for this (and just need to respond to some comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants