Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes RE protos #272

Open
xd009642 opened this issue Aug 25, 2020 · 1 comment
Open

Breaking changes RE protos #272

xd009642 opened this issue Aug 25, 2020 · 1 comment

Comments

@xd009642
Copy link
Contributor

Since protos are now being compiled into the bindings it might be nice to do some breaking changes and remove a lot of the &[u8] encoded protobuf stuff being passed around and up the minor version number. Alternatively, they can always be side by side for a while but it would be nice to eventually move to just using more "proper" types.

Is there currently a strategy for choosing which protos to add? Or a deprecation policy for how long deprecated items should remain in the code base

@xd009642
Copy link
Contributor Author

So I've created https://github.com/xd009642/tensorflow-protos-rs what this does is find all the proto files (excluding ones in tf-lite, python, contrib or examples). I then generate the code for them and feature gates! This means that you don't need to pull in everything just what you use.

My thought is that:

  1. This makes it easier to add new protos, just a case of enabling a new feature
  2. It could potentially become a public part of the API? This could potentially make it easier for people to extend the bindings in their own code. All they need is the tensorflow protos crate and they can enable extra features.

Now for 2. I'm not sure how feasible it is to extend things without exposing them via the bindings as well, but then there are a lot of protos so it might be feasible... @adamcrume if you're not opposed to this I can tidy up the crate some more and work on a PR to add this to tensorflow. I can also add you as a contributor if you'd want as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants