Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates.io version of tensorflow-internal-macros has incorrect dependency versions. #339

Open
brianjjones opened this issue Dec 28, 2021 · 2 comments
Labels

Comments

@brianjjones
Copy link
Contributor

The Cargo.toml has the correct dependencies, however crates.io appears to have not been updated. If I use tensorflow-internal-macros = "0.0.1" in my project, it imports proc-macro2 v0.4.30, quote v0.6.13, syn v0.15.44, and unicode-xid v0.1.0.

This doesn't prevent me from building, but I have a project I want to create a PR for that requires there not be any duplicate crates in the lockfile. Can you please update crates.io so that this is no longer an issue?

@adamcrume
Copy link
Contributor

Hm, it looks like I've been ignoring tensorflow-internal-macros during releases. I'll update the release instructions to fix that.

The tensorflow-internal-macros crate is entirely internal and should not be depended on directly. Can you provide a bit more detail in how you're running into this issue?

@adamcrume adamcrume added the bug label Dec 31, 2021
@brianjjones
Copy link
Contributor Author

I'm just including tensorflow = "0.17.0" in my Cargo.toml, not using tensorflow-internal-macros directly. I did a quick test of making a new rust hello world project via cargo init, then added tensorflow = "0.17.0" to it. After building, my cargo tree -d shows several duplicate packages because of the older versions being pulled in by tensorflow-internal-macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants