Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having plugins appear automatically as soon as is_active() checks is done #2102

Open
qiuminxu opened this issue Apr 9, 2019 · 0 comments
Open
Labels
core:backend plugin:profile plugin:projector plugin:text theme:ui-polish Features or fixes that make core UI more pleasant. theme:usability Areas to reduce confusion and frustration. type:cleanup

Comments

@qiuminxu
Copy link
Contributor

qiuminxu commented Apr 9, 2019

  • TensorBoard version
    1.14.0a20190319
  • TensorFlow version if different from TensorBoard
    nightly
  • OS Platform and version (e.g., Linux Ubuntu 16.04)
    Linux
  • Python version (e.g. 2.7, 3.5)
    3.5

When loading profile from gs://cloud-tpu-tools-tf13, the profile tab doesn't show up immediately. A few extra manual refreshes are required to have the profile dashboard appear. The user may not expect the extra refreshes.

The change in behavior is a consequence of #1931 which changed the is_active() computation to be asynchronous, so it's now possible that the profile dashboard shows up as inactive initially and either reloading the page or clicking the TensorBoard "refresh" icon once or twice will be necessary to have the plugin show up as active. This is the same behavior as the projector and text plugin.

I think the asynchronous computation in PR/1931 is the right way to go.
As @nfelt point out, the right answer is to change the is_active() checks to be done with 1 request per plugin (rather than all at once), and having plugins appear automatically as soon as those requests finish. Therefore opening a feature request for this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:backend plugin:profile plugin:projector plugin:text theme:ui-polish Features or fixes that make core UI more pleasant. theme:usability Areas to reduce confusion and frustration. type:cleanup
Projects
None yet
Development

No branches or pull requests

3 participants