-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Example of) support for multi-valued Box actions? #44
Comments
Hi, this seems more like an issue with the interface to gym, we will get on it, thanks for bringing it up! |
Hey, so after trying to run this, I first realized that there is a dependency to Box2D, which needs to be installed, but after doing so, it still does not work for me because of an exception from within Box2D:
Hence I'm not even getting as far as you do, unfortunately. |
Nevertheless, you're right, we are not properly translating the Gym action interface in this case (and probably others), so thanks for pointing this out. In fact, our current setup requires that actions are all single-value, i.e. 0-dimensional. I realize now that this might not always be the most convenient way, so we will change this to allow action shapes. We should be able to fix this over the weekend, I'm pretty sure. |
Great, thanks for looking into this right away. Evaluating TRPO+GAE with multiple continuous actions is particularly interesting. (openai/gym#100 covers the state of Box2D ; I had to compile pybox2d from sources to get something working.) |
Update: It turns out that a proper integration of action arrays requires quite some adaptations in various classes. Unfortunately, these changes aren't quite finished yet, but I think will be in the next 2-3 days. It will then be possible to define an action shape, e.g. |
This should work now. I haven't tried it on the BipedalWalker environment (because of the box2d problems), but let me know if it does not work. I will close this issue for now, assuming that it does. Feel free to reopen it, if it still is not working. |
Can confirm that BipedalWalker-v2's Box(4) actions are now handled just fine; thanks. |
When trying to run the TRPO agent on BipedalWalker, as follows, I run into:
Looking at
OpenAIGym.actions
, it doesn't seem to unravel that environment's Box(4) action space as wanted - am I just failing to configure the agent as required, or are such action spaces not handled right now?The text was updated successfully, but these errors were encountered: