Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error to return type of extractor #153

Open
yenicelik opened this issue Nov 27, 2023 · 0 comments
Open

Add error to return type of extractor #153

yenicelik opened this issue Nov 27, 2023 · 0 comments

Comments

@yenicelik
Copy link
Contributor

Extractors may (gracefully) fail. In these cases, they should probably return an error type.
If they don't return an error, we have two options:
(1) They return an empty object: In this case, it seems like the data has been processed, which would be false
(2) The extractor panics. In this case another set of extractors will retry extracting the initial data, in this case we will be busy for no reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant