Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial fixing #635

Merged
merged 34 commits into from Jun 1, 2018
Merged

Tutorial fixing #635

merged 34 commits into from Jun 1, 2018

Conversation

DEKHTIARJonathan
Copy link
Member

@DEKHTIARJonathan DEKHTIARJonathan commented May 17, 2018

This PR aims to insure that all the tutorial are working fine and nicely.

This PR solve the following bugs:

Tested Tutorials:

  • tutorial_atari_pong.py
  • tutorial_binarynet_cifar10_tfrecord.py
  • tutorial_binarynet_mnist_cnn.py
  • tutorial_bipedalwalker_a3c_continuous_action.py => FAILING
  • tutorial_cartpole_ac.py
  • tutorial_cifar10.py
  • tutorial_cifar10_tfrecord.py
  • tutorial_dorefanet_cifar10_tfrecord.py
  • tutorial_dorefanet_mnist_cnn.py
  • tutorial_frozenlake_dqn.py
  • tutorial_frozenlake_q_table.py
  • tutorial_generate_text.py
  • tutorial_imagenet_inceptionV3_distributed.py => Not tested yet
  • tutorial_image_preprocess.py
  • tutorial_imdb_fasttext.py
  • tutorial_inceptionV3_tfslim.py
  • tutorial_keras.py
  • tutorial_matrix.py
  • tutorial_mlp_dropout1.py
  • tutorial_mlp_dropout2.py
  • tutorial_mnist.py
  • tutorial_mnist_distributed.py => Not tested yet
  • tutorial_mnist_float16.py
  • tutorial_mnist_simple.py
  • tutorial_mobilenet.py
  • tutorial_models_mobilenetv1.py
  • tutorial_models_squeezenetv1.py
  • tutorial_models_vgg16.py
  • tutorial_ptb_lstm.py
  • tutorial_ptb_lstm_state_is_tuple.py
  • tutorial_squeezenet.py
  • tutorial_ternaryweight_cifar10_tfrecord.py
  • tutorial_ternaryweight_mnist_cnn.py
  • tutorial_tfrecord.py
  • tutorial_tfrecord2.py
  • tutorial_tfrecord3.py
  • tutorial_tfslim.py
  • tutorial_tf_dataset_voc.py
  • tutorial_vgg16.py
  • tutorial_vgg19.py
  • tutorial_word2vec_basic.py

@DEKHTIARJonathan DEKHTIARJonathan changed the title Tutorial fixing [WIP] Tutorial fixing May 17, 2018
@zsdonghao
Copy link
Member

Hi, tl.files.save_npz with sess=sess works fine now?

@DEKHTIARJonathan
Copy link
Member Author

@zsdonghao Nope, I have just applied your workaround.
And I also modified a few errors I have noticed in the tutorials. I will check that all of them run fine.

@tensorlayer tensorlayer deleted a comment May 17, 2018
@DEKHTIARJonathan
Copy link
Member Author

@zsdonghao Tutorial VGG16 is not working, can't load the checkpoint.
I have cleaned it a little but still not working, you can checkout the branch of this PR if you want ;)

@tensorlayer tensorlayer deleted a comment May 17, 2018
@tensorlayer tensorlayer deleted a comment May 17, 2018
@tensorlayer tensorlayer deleted a comment May 17, 2018
@tensorlayer tensorlayer deleted a comment May 17, 2018
@tensorlayer tensorlayer deleted a comment May 17, 2018
@DEKHTIARJonathan
Copy link
Member Author

@zsdonghao @lgarithm I don't have time to investigate why some models are not working.
I didn't try the distributed ones, I don't have the setup for it.

Could you please checkout the branch tutorial_fix and try to fix them ;)

Please tell me when some of them are fixed. That way I can flag them as good. Thanks

@tensorlayer tensorlayer deleted a comment May 28, 2018
@zsdonghao
Copy link
Member

for tutorial_tf_dataset_voc.py is seem there is a problem on the VOC website...

http://host.robots.ox.ac.uk/pascal/VOC/voc2007/

http://host.robots.ox.ac.uk/pascal/VOC/voc2012/

We can try later?

@zsdonghao
Copy link
Member

for tutorial_generate_text.py, I try in on my mac, it works well:

Start learning a model to generate text
Epoch: 1/100 Learning rate: 1.00000000
0.002 perplexity: 8721.404 speed: 2486 wps
0.100 perplexity: 1586.901 speed: 3974 wps
0.199 perplexity: 1021.575 speed: 4101 wps
0.297 perplexity: 766.037 speed: 4146 wps
0.395 perplexity: 625.603 speed: 4162 wps
0.493 perplexity: 533.806 speed: 4164 wps
0.592 perplexity: 481.060 speed: 4146 wps
0.690 perplexity: 439.476 speed: 4109 wps
0.788 perplexity: 404.770 speed: 4090 wps
0.886 perplexity: 375.800 speed: 4086 wps
0.985 perplexity: 352.464 speed: 4080 wps
Epoch: 1/100 Train Perplexity: 350.236
1 : it is a long time , and i would like that . we can not do that . we can not do that . we can not do that . we can not
3 : it is a much , but the fact is , we will make a new new jobs . we need a deal to be a long time , and i want to the
5 : it is a much for the new york . the way , the fact , i want a great time , and i had it to do , the way , and i
10 : it is a long , a lot of a lot to the oil , but a good , the world would not be the “ . ” would like the obama , and

...

@DEKHTIARJonathan
Copy link
Member Author

@zsdonghao there was an error with Unicode and Python3, I just fixed it and now it's working.

Only 4 tutorials to fix and 2 to more to test.

@tensorlayer tensorlayer deleted a comment May 29, 2018
@tensorlayer tensorlayer deleted a comment May 29, 2018
@tensorlayer tensorlayer deleted a comment May 30, 2018
@DEKHTIARJonathan
Copy link
Member Author

tutorial_tf_dataset_voc.py fixed thanks to #657

@tensorlayer tensorlayer deleted a comment May 30, 2018
@tensorlayer tensorlayer deleted a comment May 30, 2018
@tensorlayer tensorlayer deleted a comment May 30, 2018
@tensorlayer tensorlayer deleted a comment Jun 1, 2018
@DEKHTIARJonathan DEKHTIARJonathan changed the title [WIP] Tutorial fixing Tutorial fixing Jun 1, 2018
@DEKHTIARJonathan DEKHTIARJonathan merged commit 1ab2f1d into master Jun 1, 2018
TensorLayer - RoadMap automation moved this from In progress to PR Merged Jun 1, 2018
@DEKHTIARJonathan
Copy link
Member Author

@luomai and myself agreed to merge and fix later the 3 remaining tests

@DEKHTIARJonathan DEKHTIARJonathan deleted the tutorial_fix branch June 1, 2018 15:00
@DEKHTIARJonathan DEKHTIARJonathan removed this from PR Merged in TensorLayer - RoadMap Jun 1, 2018
luomai pushed a commit that referenced this pull request Nov 21, 2018
* TF bug fixing in Tutorials

* Error fix in #476

* Issue with Flags in Tutorials Fixed

* Missing import fixed

* Changelog Update

* VGG19 import error fix

* Error fixing in VGG tutorials

* TFRecord Shape Error Fix

* Sess Initialization Error Fix

* Squeezenet model loading from "models" dir

* PTB tutorials import issue fixed

* mobilenet load from dir "models"

* YAPF error fix

* Missing Import fixed

* Various Fixes on Tutorials

* YAPF error correct

* Update CHANGELOG.md

* update VGG16 tutorial, auto download model

* Python 3 Unicode Encoding Error

* Deprecation Warning Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants