-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Tensorflow support? #490
Comments
I agree, I also prefer the last option. |
We in fact already use the NumPy API in the backend. I think the crux of the issue comes down to Tensorflow (1) not supporting mutation, except through the frustrating Incidentally, we actually skip many more tests due to issues in mxnet. I would propose deprecating that before Tensorflow given its development has stopped. As for Tensorflow, maybe it is possible to get some of the skipped tests working? In that case I would recommend keeping it. If it is not possible to resolve the cases where we have used list-based indexing, it would be good to ensure there are clear errors for users when they encounter methods using this. |
Actually, it looks like |
100% agreed with @aarmey that the main problems are indexing/updating elements in Tensorflow tensors. Having a verbose and error-prone syntax using update_index, while all other backends do not need this syntax, is painful. For now #494 seems like the right move. My concern with the numpy experimental behavior is that I have no idea how stable it is. But if the changes to existing functions are minor as you suggest, it may be worthwhile to do it anyways. |
One more bit of information I found—JAX still requires I think with the new information here, I'd suggest:
Alternatively we could deprecate TensorFlow with a link to an issue to collect feedback? If nobody is using it, then removing it would be easiest and best... |
Sounds like there are little downsides to using the experimental feature of TF if we are anyway considering deprecating it. I agree @aarmey I was also reading up on JAX and looks like it's best to keep the update_index - JIT and autodiff are some of the main reasons to use that backend. |
So there has been a number of issues/PR where we ignored Tensorflow in the tests, and said that we would eventually probably deprecate Tensorflow support.
I am opening this issue so that we discuss how to proceed with this deprecation. I see a few ways to proceed:
The text was updated successfully, but these errors were encountered: