Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Models should accept parameters on creation #40

Closed
MiNeves00 opened this issue Oct 25, 2023 · 0 comments · Fixed by #44
Closed

FEAT: Models should accept parameters on creation #40

MiNeves00 opened this issue Oct 25, 2023 · 0 comments · Fixed by #44
Assignees
@MiNeves00
Labels
enhancement New feature or request

Comments

@MiNeves00
Copy link
Contributor

Feature Request

Models should also accept the parameters when created, in addition to receiving them by chat.
Chat parameters should override existing params. If no params (chat nor model) are defined default will be used.

Motivation

This allows for more intuitive code. Allows for integration with chains in langchain.

Your contribution

Will create a branch and submit a PR
@MiNeves00 MiNeves00 added the enhancement New feature or request label Oct 25, 2023
@MiNeves00 MiNeves00 assigned MiNeves00 and unassigned MiNeves00 Oct 25, 2023
@MiNeves00 MiNeves00 self-assigned this Nov 3, 2023
@MiNeves00 MiNeves00 linked a pull request Nov 3, 2023 that will close this issue
Feat/params on init #44
Merged
@MiNeves00 MiNeves00 mentioned this issue Nov 3, 2023
Merged
claudiolemos added a commit that referenced this issue Nov 6, 2023
@claudiolemos
Feat/params on init (#44)
2cd676a 
Added feature from #40, however currently only supports OpenAI. Support
for other providers should be trivial.
In summary the client.get_model now also takes in params. This was
necessary for the integration with langchain.
If parameters are provided in the .chat function, they override the ones
set in the get_model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiNeves00 MiNeves00

Labels
enhancement New feature or request
Projects
LLMstudio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/params on init TensorOpsAI/LLMstudio
1 participant
@MiNeves00