Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support observing and trading multiple assets at a time #57

Closed
notadamking opened this issue Oct 20, 2019 · 19 comments
Closed
Labels
$$$ 1+ $ETH in Funding enhancement New feature or request funded This issue is funded via Gitcoin. help wanted Extra attention is needed

Comments

@notadamking
Copy link
Collaborator

notadamking commented Oct 20, 2019

Funding:
1.5 ETH (~$300 USD)

Description:
Create the necessary components to support observing multiple assets from an exchange, applying a feature pipeline to those assets, and making a trade on any of those assets.

Requirements:

  • Create the necessary InstrumentExchange components (or update existing components) to support observing/trading multiple assets on both a simulated and live exchange.
  • Ensure the exchanges support feeding their observations through a simple feature pipeline.
  • Create the necessary ActionStrategy component(s) to support trading multiple assets at a time.
  • Create the necessary RewardStrategy component(s) for rewarding multiple concurrent trades.
  • Create the necessary unit tests to confirm the new components are working as expected.

TensorTrade tutorial article

@notadamking notadamking added enhancement New feature or request help wanted Extra attention is needed funded This issue is funded via Gitcoin. labels Oct 20, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0 ETH (171.83 USD @ $171.83/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of this issue was increased to 1.5 ETH (257.2 USD @ $171.47/ETH) .

@notadamking notadamking added the $$$ 1+ $ETH in Funding label Oct 20, 2019
@gitcoinbot
Copy link

@sirlupinwatson1 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@sirlupinwatson
Copy link
Contributor

Funding:
1.5 ETH (~$300 USD)

Description:
Create the necessary components to support observing multiple assets from an exchange, applying a feature pipeline to those assets, and making a trade on any of those assets.

Requirements:

* Create the necessary `InstrumentExchange` components (or update existing components) to support observing/trading multiple assets on both a simulated and live exchange.

* Ensure the exchanges support feeding their observations through a simple feature pipeline.

* Create the necessary `ActionStrategy` component(s) to support trading multiple assets at a time.

* Create the necessary `RewardStrategy` component(s) for rewarding multiple concurrent trades.

* Create the necessary unit tests to confirm the new components are working as expected.

TensorTrade tutorial article

Hello @notadamking , i started to work on this, but not sure where i should end it

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.5 ETH (274.87 USD @ $183.25/ETH) has been submitted by:

  1. @sirlupinwatson1

@notadamking please take a look at the submitted work:

  • (Link Not Provided) by @Sirlupinwatson1

@sirlupinwatson
Copy link
Contributor

I wish i could have done much, but still tryng to figure some things out. i try to give you a link to my saved folder
sorry about that @notadamking

@notadamking
Copy link
Collaborator Author

@Sirlupinwatson1 I do not see any submission.

@sirlupinwatson
Copy link
Contributor

@Sirlupinwatson1 I do not see any submission.

Hi, sorry i just arrive, but yes, i have a sub with work done

@sirlupinwatson
Copy link
Contributor

@notadamking yesterday or 2 days ago i did add the code of conduct, it was missing , but i did build also and did all the test. i cloned my own and add my touch, it took me long to think about it because other project are happening at the sametime and lot of data here around :)

@sirlupinwatson
Copy link
Contributor

@notadamking i look for it now, i just finished my meeting. Sorry also about that. Thas is pretty bad since yesterday ive done all this for nothing haha. it should be somewhere

@notadamking
Copy link
Collaborator Author

@Sirlupinwatson1 you are still welcome to submit a PR, though the code bounty is on a first come first serve basis at this point.

@sirlupinwatson
Copy link
Contributor

@notadamking , just to clarify, its always the first come first served ? its not judging by the quality work and time we took to do it ?

@notadamking
Copy link
Collaborator Author

First come, first serve, if the quality is high enough :)

@jeevanpillay
Copy link

has this been submitted yet?

@sirlupinwatson
Copy link
Contributor

@lpfloyd NO, you can win this

@ghost
Copy link

ghost commented Nov 6, 2019

Hey!
Started reading up on the linked post and implemented a basic TradingStrategy.
Would get into finer details now.

Question: How frequently should I be posting my updates here?

@gitcoinbot
Copy link

gitcoinbot commented Nov 13, 2019

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 1 week, 1 day from now.
Please review their action plans below:

1) kaus2595 has been approved to start work.

I would like to work on the issue if available

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 1.5 ETH (218.85 USD @ $145.9/ETH) attached to this issue has been cancelled by the bounty submitter

@notadamking
Copy link
Collaborator Author

Solved by #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$$$ 1+ $ETH in Funding enhancement New feature or request funded This issue is funded via Gitcoin. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants