Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Album, Photos, chicken, egg #126

Closed
tobiastom opened this issue Oct 20, 2012 · 7 comments
Closed

Album, Photos, chicken, egg #126

tobiastom opened this issue Oct 20, 2012 · 7 comments

Comments

@tobiastom
Copy link

Right now it seems that you have to post photos before you can post an album. It makes sense from a technical point, but in a feed of an client application it does not make any sense.

If someone posts five photos, they would appear in my stream. If the same person now creates an album with the IDs of the given photos, my stream would display an album with the same five images I've already seen.

I really like the flexibility this provides, but maybe there should be some "partOfAlbum" attribute or something like that, that could client help to not display the images separately in a stream, but only in the following album post…

@alexwright
Copy link

You could post an album first, and then start posting photos to the album. Still far from ideal.

Rather than make a partOfAlbum one-use property of the photo type, it might be more useful to add a dontNecessarilySendOutNotifications boolean that would work on all types?

@tobiastom
Copy link
Author

I agree that it might be better to have a general solution. Still I don't think the name should be related to notifications. Maybe some "standalone" property which is true by default on each post type, and can be changed to false, which clients should consider as "not to display as a standalone post".

Am 20.10.2012 um 20:15 schrieb Alex notifications@github.com:

You could post an album first, and then start posting photos to the album. Still far from ideal.

Rather than make a partOfAlbum one-use property of the photo type, it might be more useful to add a dontNecessarilySendOutNotifications boolean that would work on all types?


Reply to this email directly or view it on GitHub.

@mwanji
Copy link

mwanji commented Oct 21, 2012

Right now it seems that you have to post photos before you can post an album

It also seems that you have to update the photos with the album ID once it has been created. Is that the case?

Why can't we create an album with an array of photos, rather than of photo IDs?

@tobiastom
Copy link
Author

I would agree on that… still this would take a lot of the flexibility. e.g. adding photos to an album later…

Am 21.10.2012 um 17:57 schrieb Moandji Ezana notifications@github.com:

Right now it seems that you have to post photos before you can post an album

It also seems that you have to update the photos with the album ID once it has been created. Is that the case?

Why can't we create an album with an array of photos, rather than of photo IDs?


Reply to this email directly or view it on GitHub.

@mwanji
Copy link

mwanji commented Oct 21, 2012

Not necessarily. I assume that currently, to add a photo to an album, you
have to get the existing album JSON and append a new ID to the photos
array. If that array accepts both IDs and Photo objects, the same could be
done and it would be up to the server to figure it out.

@tobiastom
Copy link
Author

You are right, but it kind of adds a lot of complexity to two simple post types. I still think the standalone property would be better… and more generalized.

Am 21.10.2012 um 18:21 schrieb Moandji Ezana notifications@github.com:

Not necessarily. I assume that currently, to add a photo to an album, you
have to get the existing album JSON and append a new ID to the photos
array. If that array accepts both IDs and Photo objects, the same could be
done and it would be up to the server to figure it out.

Reply to this email directly or view it on GitHub.

@titanous
Copy link
Member

The albums member will be removed from the photo type (#183).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants