Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types not published on npm ? #18

Closed
xawill opened this issue Jun 16, 2021 · 5 comments
Closed

Types not published on npm ? #18

xawill opened this issue Jun 16, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@xawill
Copy link

xawill commented Jun 16, 2021

While trying to add the library to my app, I noticed that the npm package only contains javascript code and no typings. Is it intentional ? Do you plan to publish the types as well ? We definitely both see the benefits of coding the library in typescript, but this is also useful to use it in typescript.

Thanks a lot!

@xawill
Copy link
Author

xawill commented Jun 19, 2021

Based on this, it looks like the only think you have to do is to set declaration to true here:

"declaration": false,

Thanks again for the library !

@tentone
Copy link
Owner

tentone commented Jun 24, 2021

Hello

Thanks a lot for reporting this issue.

I have enabled the type declarations that will be published to npm on next release today.

Cheers

@tentone tentone added the bug Something isn't working label Jun 24, 2021
@christjt
Copy link
Contributor

This issue is fixed and can be closed once a new released is published.

@christjt
Copy link
Contributor

@tentone Hey! Can you make a new NPM release with the added types? 😀

@tentone
Copy link
Owner

tentone commented Aug 28, 2021

Hello

Types are now published into NPM.

Thanks a lot! And Sorry for the delay!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants