Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per partition memory usage information to vast status #1297

Merged
merged 17 commits into from Jan 26, 2021
Merged

Add per partition memory usage information to vast status #1297

merged 17 commits into from Jan 26, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Jan 21, 2021 •
edited

📔 Description

Collects memory usage statistics from partition actors and active indexers via the status message.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

By commit.

@tobim tobim force-pushed the tdhtf/story2985/index-memory branch from 4691709 to 6279662 Compare January 21, 2021 07:44
@tobim tobim requested a review from a team January 21, 2021 07:45
dominiklohmann
dominiklohmann reviewed Jan 21, 2021
View reviewed changes
libvast/vast/chunk.hpp Outdated Show resolved Hide resolved
libvast/vast/ewah_bitmap.hpp Show resolved Hide resolved
@tobim tobim force-pushed the tdhtf/story2985/index-memory branch from 3ff5a5d to 8b142d3 Compare January 21, 2021 10:17
@tobim tobim force-pushed the tdhtf/story2985/index-memory branch from 8b142d3 to 5589ec1 Compare January 26, 2021 08:57
@tobim tobim force-pushed the tdhtf/story2985/index-memory branch from 5589ec1 to 4a17f4a Compare January 26, 2021 11:41
@tobim tobim enabled auto-merge January 26, 2021 11:47
@tobim tobim force-pushed the tdhtf/story2985/index-memory branch from 817a364 to 46615ad Compare January 26, 2021 13:39
dominiklohmann
dominiklohmann approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well on my machine, and the code lgtm as well! 🚀

@tobim tobim merged commit 691c0b1 into master Jan 26, 2021
@tobim tobim deleted the tdhtf/story2985/index-memory branch January 26, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tobim @dominiklohmann