Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the transformer actor #2896

Merged
merged 16 commits into from Feb 2, 2023
Merged

Conversation

Dakostu
Copy link
Member

@Dakostu Dakostu commented Jan 31, 2023

https://github.com/tenzir/issues/issues/72 makes the transformer actor obsolete, so here is a quick removal (with the table_slice transformation responsibility moved to the components that formerly used the transformer).

Fixes tenzir/issues#11

@Dakostu Dakostu added the refactoring Restructuring of existing code label Jan 31, 2023
@Dakostu Dakostu requested a review from a team January 31, 2023 08:03
@Dakostu Dakostu marked this pull request as ready for review February 1, 2023 10:37
libvast/src/system/importer.cpp Outdated Show resolved Hide resolved
libvast/src/system/importer.cpp Show resolved Hide resolved
libvast/src/system/source.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@patszt patszt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just requires the agreement on the changelog side and i think it is good to go

@Dakostu
Copy link
Member Author

Dakostu commented Feb 2, 2023

If there are no objections from you @dominiklohmann @tobim I will merge this by 15:00 CET. I will merge earlier if you approve the PR.

@dominiklohmann
Copy link
Member

Go ahead, I think this is ready to go!

@Dakostu Dakostu merged commit 7dcc2bc into master Feb 2, 2023
@Dakostu Dakostu deleted the topic/remove-the-transformer-actor branch February 2, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Restructuring of existing code
Projects
None yet
4 participants